search

herzbube / littlego

Little Go. An iOS application that lets you play the game of Go on the iPhone or iPad.
https://littlego.herzbube.ch/
Apache License 2.0
138 stars 53 forks source link

EditTextController ignores "acceptEmptyText" property when clearing text #340

Closed herzbube closed 3 years ago

herzbube commented 3 years ago

Steps to reproduce:

  1. EditTextController is created with the acceptEmptyText property set to true
  2. User taps the "x" button in the edit text field, clearing all input text that is currently in the text field

Expected: The text is cleared and the "Done" button is enabled. Actual: The text is cleared and the "Done" button is disabled.

None of the data entry screens currently in production are affected by this bug. The only data entry screen that sets the acceptEmptyText property to true is the one where the user enters GTP profile notes (Settings > Players & Profiles > Select any profile > Tap "Profile Notes" item), but there the EditTextController is created with the "text view" style, which does not display the "x" button.