herzbube / littlego

Little Go. An iOS application that lets you play the game of Go on the iPhone or iPad.
https://littlego.herzbube.ch/
Apache License 2.0
138 stars 53 forks source link

Add DEBUG flag and exclude GoogleService plist in debug target #352

Closed dingbat closed 3 years ago

dingbat commented 3 years ago
dingbat commented 3 years ago

I'm actually now realizing maybe you do want this on a debug build running on the device, in case you are playing with the development version untethered and get a crash, so this may not be the best solution. Let me know.

herzbube commented 3 years ago

I'm actually now realizing maybe you do want this on a debug build running on the device, in case you are playing with the development version untethered and get a crash, so this may not be the best solution. Let me know.

No, you're right, crash reporting is not something I regularly want. It's just that up until now I never had the need to disable it because I, of course, own the GoogleService-Info.plist file. You're the first contributor, so you have the dubious honor of finding all the obstacles I built into the project 🙂.

Instead of defining a new preprocessor macro, could you please use the already existing macro LITTLEGO_NDEBUG? This is defined in all configurations except in debug builds, so setupCrashReporting should use

#ifdef LITTLEGO_NDEBUG

If I ever need crash reporting in a debug build I will fiddle with the project until I get it running.