m/ filter does not work for unverified clients

hessu / aprsc

aprsc, a core APRS-IS server

124 stars 40 forks source link

m/ filter does not work for unverified clients #26

Closed hessu closed 9 years ago

hessu commented 9 years ago

m/ looks up the position from the historydb (cache of last positions from the APRS-IS stream) based on the connected client's username, and the historydb only gets populated by packets accepted to the stream. As a result, m/ filters do not work unless you're verified and can send packets to the IS.

Should put lat/lon/cos_lat to client struct and use that for m/ filter range calculation.

Reported by Ge0rG.

hessu commented 9 years ago

Fixed in v2.0.16:

Packet is parsed before dropping it due to it being from unvalidated client
Client location is stored in client struct
m/ filter uses client struct instead of historydb for client location

As a side effect, some packets will be dropped due to other errors, before the "unvalidated client" error will be detected.