search

hestiaAI / hestialabs-experiences

HestiaLabs Data Experiences & Digipower Academy
https://digipower.academy
Other
7 stars 1 forks source link

Charts should not need a vuex store, I think #1161

Closed andreaskundig closed 1 year ago

andreaskundig commented 1 year ago

The mixin for charts tries to access the name of the current tab, but we want to be able to use visualizations outside of experience tabs.

  data() {
    return {
      graphId: 'graph_' + this.$store.state.xp.currentTab,
      totalCount: 0,
      filterCount: 0
    }
  },

https://github.com/hestiaAI/hestialabs-experiences/blob/431db2037d831d646549b9e0b40acef30c232526/data-experience/src/components/chart/view/mixin.js#L21..L28

valentinoli commented 1 year ago

Yes, this can be avoided