Closed alexbfree closed 2 years ago
Issues found in Uber experience:
Within "Vue d'ensemble" all text within visualisations is showing in English. Specifically:
Under Trajets:
Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:
The rest are not globalised it seems:
On the Carte de Trajets
Tab Name:
Keys that need values for French:
Other
For Twitter experience.
Under Vue d'ensemble des publicités:
Under criteres de ciblages (tous):
Under criteres de ciblages (1):
Under donnees supposees
Timeline:
Other
see also related issue https://github.com/hestiaAI/hestialabs-experiences/issues/884
"Copyright" was left untouched on purpose, since it is commonly used in French
For Tinder:
For Instagram:
general:
On Timeline tab:
On Vues tab:
On Likes tab:
On Messages tab:
On Liste de suivi tab:
On all Table Filters, all Tables, All Experiences:
On Netflix experience:
General:
On Timeline tab:
(By the way, the way this has been globalised is not best practice, as it relies on the word order remaining the same when you change language. Best practice is to use a string for the whole sentence, with variable substitution markers, this can support any word order across languages. Not an issue for English/French, but it is technical debt for later)
On Notifications tab:
All time range selector graphs on all experiences:
Google Experience:
Endroits visités:
Un Endroit Particulier:
Autres candidats:
Trajets:
Historique:
wifi:
LinkedIn Experience:
Ciblage Publicitaire:
Connections:
General
Timeline tab
Facebook experience:
Interactions tab:
Interets supposes
General
Timeline tab
Location observations tab:
Issues in generic experience:
Observations de localisation
@andreaskundig @valentinoli
All experiences are now tested (except Tiktok not there yet) and all found issues are flagged above. This ticket can be worked on. Also raised along the way:
I only had time to double-check facebook, twitter, instagram, twitter (I couldn't see most instagram visualizations because our example data in the kdrive doesn't have many required files)
For testing:
@valentinoli to deploy, @alexbfree to test
@alexbfree Ready for testing. Deployed on https://test.hestialabs.org
@andreaskundig @valentinoli can you provide any further information on how to test
Phew, here goes, a very long list of tests for me to do
Under Trajets:
Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:
The rest are not globalised it seems:
Tab Name:
Keys that need values for French:
Other
Under Vue d'ensemble des publicités:
Under criteres de ciblages (tous):
Under criteres de ciblages (1):
Under donnees supposees
Timeline:
Other
general:
On Timeline tab:
On Vues tab:
On Likes tab:
On Messages tab:
On Liste de suivi tab:
On Netflix experience:
General:
On Timeline tab:
(By the way, the way this has been globalised is not best practice, as it relies on the word order remaining the same when you change language. Best practice is to use a string for the whole sentence, with variable substitution markers, this can support any word order across languages. Not an issue for English/French, but it is technical debt for later)
On Notifications tab:
Google Experience:
Endroits visités:
Un Endroit Particulier:
Autres candidats:
Trajets:
Historique:
wifi:
Ciblage Publicitaire:
Connections:
General
Timeline tab
Interactions tab:
Interets supposes
General
Timeline tab
Location observations tab:
Observations de localisation
======
Under Trajets:
Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:
The rest are not globalised it seems:
On the Carte de Trajets
Tab Name:
Keys that need values for French:
Other
Under Vue d'ensemble des publicités:
Under criteres de ciblages (tous):
Under criteres de ciblages (1):
Under donnees supposees
Timeline:
Other
general:
On Timeline tab:
On Vues tab:
On Likes tab:
On Messages tab:
On Liste de suivi tab:
On Netflix experience:
General:
On Timeline tab:
On Notifications tab:
Google Experience:
Endroits visités:
Un Endroit Particulier:
Autres candidats:
Trajets:
Historique:
wifi:
Ciblage Publicitaire:
Connections:
General
Timeline tab
Interactions tab:
Interets supposes
General
Timeline tab
Location observations tab:
Observations de localisation
[x] typo: Visulalisation interactive de vos habitudes sur Uber
[x] experiences.instagram.viewBlocks.likes.selected is shown as key without translation in french.
Sélectionnez une <span class='font-weight-bold'>plage de temps</span> pour effectuer un zoom
Total Messages
I think no action is needed on these, pending decisions of https://github.com/hestiaAI/internal-discussions/issues/56
I have done almost all of the tests, except two tabs on Facebook. I need a different Facebook data file that doesn't hit issue https://github.com/hestiaAI/hestialabs-experiences/issues/1042
Have requested new Facebook file in the hope that this was just a rare occurrence affecting one file.
since there are bugs that can be fixed, I will pass this back to Development needed.
See https://github.com/hestiaAI/hestialabs-experiences/issues/932#issuecomment-1260952166 for details of issues found. Just a few - generally all works great!
@valentinoli may wish to comment, though it need not necessarily be Valentin who fixes the issues found.
Awaiting #1048 for test deployment
Deployed to test.hestialabs.org and assigned to @alexbfree
Tests passed and closing
I am doing some testing on the deployment of code for a client that Andreas put at deployment-example-experiences.netlify.app. I will add places where I have found text in English or other issues by editing this ticket. Will add a comment when done.