hestiaAI / hestialabs-experiences

HestiaLabs Data Experiences & Digipower Academy
https://digipower.academy
Other
7 stars 1 forks source link

internationalisation/globalisation issues: testing of deployment-example-experiences.netlify.app #932

Closed alexbfree closed 2 years ago

alexbfree commented 2 years ago

I am doing some testing on the deployment of code for a client that Andreas put at deployment-example-experiences.netlify.app. I will add places where I have found text in English or other issues by editing this ticket. Will add a comment when done.

alexbfree commented 2 years ago

Issues found in Uber experience:

Within "Vue d'ensemble" all text within visualisations is showing in English. Specifically:

Under Trajets:

Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:

The rest are not globalised it seems:

On the Carte de Trajets

Tab Name:

Keys that need values for French:

Other

alexbfree commented 2 years ago

For Twitter experience.

Under Vue d'ensemble des publicités:

Under criteres de ciblages (tous):

Under criteres de ciblages (1):

Under donnees supposees

Timeline:

Other

alexbfree commented 2 years ago

see also related issue https://github.com/hestiaAI/hestialabs-experiences/issues/884

valentinoli commented 2 years ago

"Copyright" was left untouched on purpose, since it is commonly used in French

pdehaye commented 2 years ago

For Tinder:

alexbfree commented 2 years ago

For Instagram:

general:

On Timeline tab:

On Vues tab:

On Likes tab:

On Messages tab:

On Liste de suivi tab:

alexbfree commented 2 years ago

On all Table Filters, all Tables, All Experiences:

alexbfree commented 2 years ago

On Netflix experience:

General:

On Timeline tab:

(By the way, the way this has been globalised is not best practice, as it relies on the word order remaining the same when you change language. Best practice is to use a string for the whole sentence, with variable substitution markers, this can support any word order across languages. Not an issue for English/French, but it is technical debt for later)

On Notifications tab:

alexbfree commented 2 years ago

All time range selector graphs on all experiences:

alexbfree commented 2 years ago

Google Experience:

Endroits visités:

Un Endroit Particulier:

Autres candidats:

Trajets:

Historique:

wifi:

alexbfree commented 2 years ago

LinkedIn Experience:

Ciblage Publicitaire:

Connections:

General

Timeline tab

alexbfree commented 2 years ago

Facebook experience:

Interactions tab:

Interets supposes

General

Timeline tab

Location observations tab:

alexbfree commented 2 years ago

Issues in generic experience:

Observations de localisation

alexbfree commented 2 years ago

@andreaskundig @valentinoli

All experiences are now tested (except Tiktok not there yet) and all found issues are flagged above. This ticket can be worked on. Also raised along the way:

andreaskundig commented 2 years ago

I only had time to double-check facebook, twitter, instagram, twitter (I couldn't see most instagram visualizations because our example data in the kdrive doesn't have many required files) 

valentinoli commented 2 years ago
alexbfree commented 2 years ago

For testing:

alexbfree commented 2 years ago

@valentinoli to deploy, @alexbfree to test

valentinoli commented 2 years ago

@alexbfree Ready for testing. Deployed on https://test.hestialabs.org

alexbfree commented 2 years ago

@andreaskundig @valentinoli can you provide any further information on how to test

alexbfree commented 2 years ago

Phew, here goes, a very long list of tests for me to do


Testing checklist. FRENCH

Uber

Under Trajets:

Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:

The rest are not globalised it seems:

Tab Name:

Keys that need values for French:

Other


Twitter

Under Vue d'ensemble des publicités:

Under criteres de ciblages (tous):

Under criteres de ciblages (1):

Under donnees supposees

Timeline:

Other


Tinder


Instagram

general:

On Timeline tab:

On Vues tab:

On Likes tab:

On Messages tab:

On Liste de suivi tab:


 Netflix

On Netflix experience:

General:

On Timeline tab:

(By the way, the way this has been globalised is not best practice, as it relies on the word order remaining the same when you change language. Best practice is to use a string for the whole sentence, with variable substitution markers, this can support any word order across languages. Not an issue for English/French, but it is technical debt for later)

On Notifications tab:


All


Google

Google Experience:

Endroits visités:

Un Endroit Particulier:

Autres candidats:

Trajets:

Historique:

wifi:


LinkedIn

Ciblage Publicitaire:

Connections:

General

Timeline tab


Facebook

Interactions tab:

Interets supposes

General

Timeline tab

Location observations tab:


Generic

Observations de localisation


======

Testing checklist -- ENGLISH

Uber

Under Trajets:

Under Timeline: (these seem to be globalised but no text being rendered for French, only language keys:

The rest are not globalised it seems:

On the Carte de Trajets

Tab Name:

Keys that need values for French:

Other


Twitter

Under Vue d'ensemble des publicités:

Under criteres de ciblages (tous):

Under criteres de ciblages (1):

Under donnees supposees

Timeline:

Other


Tinder


Instagram

general:

On Timeline tab:

On Vues tab:

On Likes tab:

On Messages tab:

On Liste de suivi tab:


 Netflix

On Netflix experience:

General:

On Timeline tab:

On Notifications tab:


All


Google

Google Experience:

Endroits visités:

Un Endroit Particulier:

Autres candidats:

Trajets:

Historique:

wifi:


LinkedIn

Ciblage Publicitaire:

Connections:

General

Timeline tab


Facebook

Interactions tab:

Interets supposes

General

Timeline tab

Location observations tab:


Generic

Observations de localisation


alexbfree commented 2 years ago

Failed Tests / Noticed Issues

French

Uber - Vue d'ensemble tab

Instagram - Messages tab


value translation issues

I think no action is needed on these, pending decisions of https://github.com/hestiaAI/internal-discussions/issues/56

Twitter - Criteres de Ciblage (1 pub)

Twitter - Données supposées

Facebook - Interactions tab

 Google


For a separate ticket

Generic Explorer

Google - Autres Candidats tab AND Trajets tab

alexbfree commented 2 years ago

I have done almost all of the tests, except two tabs on Facebook. I need a different Facebook data file that doesn't hit issue https://github.com/hestiaAI/hestialabs-experiences/issues/1042

Have requested new Facebook file in the hope that this was just a rare occurrence affecting one file.

alexbfree commented 2 years ago

since there are bugs that can be fixed, I will pass this back to Development needed.

See https://github.com/hestiaAI/hestialabs-experiences/issues/932#issuecomment-1260952166 for details of issues found. Just a few - generally all works great!

@valentinoli may wish to comment, though it need not necessarily be Valentin who fixes the issues found.

valentinoli commented 2 years ago

Awaiting #1048 for test deployment

valentinoli commented 2 years ago

Deployed to test.hestialabs.org and assigned to @alexbfree

valentinoli commented 2 years ago

Tests passed and closing