hestiaAI / hestialabs-experiences

HestiaLabs Data Experiences & Digipower Academy
https://digipower.academy
Other
7 stars 1 forks source link

UnitFilterableTable updates Vuex store with postprocessed data #997

Open valentinoli opened 2 years ago

valentinoli commented 2 years ago

UnitFilterableTable receives postprocessed data from a parent chart view component. This results in postprocessed (and often transformed) data being uploaded to the Vuex store by the table component and, in turn, uploaded to the bubble server. Only the table component displayed with the showTable flag receives non-postprocessed data (see UnitQuery).

valentinoli commented 2 years ago

Relevant code snippets (might also post a diagram later)

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/unit/UnitQuery.vue#L230-L241

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/unit/filterable-table/UnitFilterableTable.vue#L203-L220

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/unit/UnitQuery.vue#L101-L105

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/unit/UnitQuery.vue#L85-L93

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/chart/view/ChartViewOverviewTwitter.vue#L91

https://github.com/hestiaAI/hestialabs-experiences/blob/8dab76e2b291570a54d45af99b74ed1f1623a94e/experiences/components/chart/view/ChartViewOverviewTwitter.vue#L173-L181

andreaskundig commented 2 years ago

We disabled sharing postprocessed data. We need a new way to filter the data before sharing.

andreaskundig commented 2 years ago

@valentinoli will create a diagram about this