[Bug] Domain encoding when updating letsencrypt certificates

[stahiy]

Describe the bug

When executing the /bin/v-update-letsencrypt-ssl command on line 85. Domain encoding in web.conf and in the certificate file (aliases) may vary. In web.conf maybe 'räksmörgås.se', but in the certificate 'xn--rksmrgs-5wao1o.se'

Tell us how to replicate the bug

1. Create a domain in English through the panel. (domain.com).
2. Add aliases in another language to the domain Not in punycode. ('räksmörgås.se')
3. Create a letsencrypt certificate for these domains through the panel.
4. Update the certificate using the v-update-letsencrypt-ssl command from the console

Which components are affected by this bug?

Let's Encrypt SSL

Hestia Control Panel Version

1.88

Operating system

Ubuntu 20.04

Log capture

No response

[jaapmarcus]

In certificates it should be listed as punycode other wise it will not work

[stahiy]

The problem is not with the certificate. And in web.conf. In web.conf the domain may not be in punicode.

[jaapmarcus]

The problem is not with the certificate. And in web.conf. In web.conf the domain may not be in punicode.

That should not be an issue we convert them when we create the config files...

[ponasromas]

IDN format is standard. Always store IDN domains in that format. Only if you need display it to end-user - convert to räksmörgås.se

[jaapmarcus]

IDN format is standard. Always store IDN domains in that format. Only if you need display it to end-user - convert to räksmörgås.se

I know but good luck upgrading existing systems.. We currently convert in every config file when needed and it should work fine with the issues.

If it would update from the ground up I would probally make different setup changes...