Some clean ups - Githubissues

hetelek / Velocity

A cross-platform application built using the Qt framework that allows you to browse and edit Xbox 360 files.

GNU General Public License v3.0

162 stars 47 forks source link

Some clean ups #7

Closed AndoniZubimendi closed 11 years ago

AndoniZubimendi commented 11 years ago

Hi!

I am doing some clean ups and qt-ification.

Changed std::vector to QVector
Changed most of std::string to QString (std::wstring still pending)
Changed some const arguments to methods to const references to avoid copying.
Remove the "using" directive of the headers, as it is not recommended
All the exceptions now throws QString instead of std::string
Remove some unneded #includes from some headers.

I am doing this on my way to understand the program, let me know if you are interested in this kind of work or if you think I can help you guys in something.

hetelek commented 11 years ago

Hey, Andoni. We actually love that you are helping Velocity, and hope you continue to do so. I currently do not have time to check over these changes, but I see that you change many std::string to QString's. we appreciate this, but all strings in the StfsPackage/GPD stuff we'd like to keep as a std::string because we do not want to use the Qt libraries in those. So another way to see it is, all Xbox classes should stay Qt-free as we may compile a DLL and we wouldn't want Qt to be required. Thanks again for your changes, we really appreciate any help and hope you continue to help us.

AndoniZubimendi commented 11 years ago

If you want to keep Xbox classes Qt-free, then ignore/close this pull request. When I make some time I will try make something similar but not touching the standar classes.