search

hetima / DSP_LSTM

Mod for Dyson Sphere Program
https://dsp.thunderstore.io/package/hetima/LSTM/
The Unlicense
15 stars 5 forks source link

minor changes needed to make today's DSP patch work again. #31

Closed geeksville closed 8 months ago

geeksville commented 8 months ago

I'm a novice modder and haven't written any C# for a long time. But seems to be a good fix on my machine. If useful here's a fix @hetima.

Probably not cool for me to send out my built dll. So I presume others will need to wait for Hetima's review and possible release.

geeksville commented 8 months ago

fix #29 (to have github tag correctly)

geeksville commented 8 months ago

fix #30

alnet commented 8 months ago

This looks like it would work, though I haven't touched c# in ages. What's needed to build it these days? If I can build it locally I'll build it took for at least another person to test.

geeksville commented 8 months ago

@alnet it definitely works ;-)

Here's a temporary dll to hold you over (usual caveats about trusting binaries from strangers tho ;-)) LSTM.zip

geeksville commented 8 months ago

but in theory (at least on my linux machine) the only thing needed to build is to cd into the dir and "dotnet build". I used dotnet 7.0

alnet commented 8 months ago

but in theory (at least on my linux machine) the only thing needed to build is to cd into the dir and "dotnet build". I used dotnet 7.0

Oh I hadn't touched C# since the dotnet on linux thing either. I had no idea it could cross build, that's very cool and I'll give it a shot, specifically because of binaries from strangers. :) Thanks for the info in any case!

alnet commented 8 months ago

but in theory (at least on my linux machine) the only thing needed to build is to cd into the dir and "dotnet build". I used dotnet 7.0

Oh I hadn't touched C# since the dotnet on linux thing either. I had no idea it could cross build, that's very cool and I'll give it a shot, specifically because of binaries from strangers. :) Thanks for the info in any case!

Forgot to add, compiling locally in linux for me as well, few hours of game time now with no further issues, so for everyone else monitoring this PR, you can install linux ubuntu in a vm and build this branch yourself all for free if you don't want to figure out windows build environment, or use the provided dll if you trust a binary from internet strangers. :D

hetima commented 8 months ago

thanks!

Thilenios commented 8 months ago

Will you be pushing this out to the store page? I use R2modman and have no idea how to do it manually haha

hetima commented 8 months ago

0.8.6 released

geeksville commented 8 months ago

thanks again for making this @hetima !