search

hetio / het.io

Source code for https://het.io website
Other
6 stars 3 forks source link

Change "relationships" to "edges" #33

Closed dhimmel closed 4 years ago

dhimmel commented 5 years ago

I'll comment below with any tooltip tweaks we should make

dhimmel commented 5 years ago

At https://hetio.github.io/repurpose-frontend/?tab=diseases&id=DOID_2841

image

Highlighted term should be "edges" not "relationships" for consistency with other tables.

Also effects https://hetio.github.io/repurpose-frontend/?tab=compounds&id=DB01048

dhimmel commented 5 years ago

https://hetio.github.io/repurpose-frontend/?tab=metapaths only has 121 rows, but should have many more (1206). My guess is that all rows with a missing coefficient have been filtered out?

vincerubinetti commented 4 years ago

https://hetio.github.io/repurpose-frontend/?tab=metapaths only has 121 rows, but should have many more (1206). My guess is that all rows with a missing coefficient have been filtered out?

121 is the number of pages, not number rows. So that means there are at least 1210 rows. The number of rows is shown in the upper left corner:

image

dhimmel commented 4 years ago

The number of rows is shown in the upper left corner:

Ah got it. The metapaths table has the right number of entries, but it looks like the null coefficients are getting set to 0.000. They should remain blank because they are distinct from the actual zeros.

vincerubinetti commented 4 years ago

Closed by https://github.com/hetio/repurpose-frontend/pull/20