hetio / hetionet

Hetionet: an integrative network of disease
https://neo4j.het.io
264 stars 69 forks source link

Improve consistency and accessibility of metanode colors #18

Closed vincerubinetti closed 5 years ago

vincerubinetti commented 5 years ago

old: old new: new @dhimmel

dhimmel commented 5 years ago

The side-by-side comparison is nice.

A few things we might also want to include in this PR:

Then following this PR we probably want to update the two metagraph visualizations here. I made these with the macOS OmniGraffle program. Perhaps I could dust off the old machine to update them.

vincerubinetti commented 5 years ago

image

vincerubinetti commented 5 years ago

Done :+1: ready to merge

dhimmel commented 1 year ago

We were asked by a reviewer about the whether the Hetionet color palettes are color blind friendly, so I made the following figure using http://hclwizard.org:3000/cvdemulator/:

hetionet-metagraph-colorblindness-simulator

It's interesting to see how the colors appear based on different color vision deficiencies. Many of the colors are still differentiable. Also we often show the metanode name or abbreviation along with the colors, such that I don't think any action is needed, just something to consider.

vincerubinetti commented 1 year ago

I don't proclaim to be an expert in accessibility or color theory, but I think the best way to make something "color blind friendly" is to make it not rely on colors at all, as you said. Then colors can just be a bonus. I think there's only so much you can do when certain color blindnesses limit you to only ~3 hues, and we have 8 types here. A true expert in color accessibility could probably tweak the brightnesses and saturations and such to be slightly more differentiable, but probably not worthwhile enough to change all the code and figures. I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.

dhimmel commented 1 year ago

I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.

Yes. The visualizations would work without color at all, but would be less pretty.

Looking at the commits in this PR, I see 7417ce940b3cca42231ae4128f4abca5b535e892 with message, "improve consistency and accessibility of metanode colors", so I'm inclined to think that accessibility was a criteria for your revisions.