hetio / hetionet

Hetionet: an integrative network of disease
https://neo4j.het.io
257 stars 68 forks source link

Make implied directed edges explicit #23

Open vincerubinetti opened 5 years ago

vincerubinetti commented 5 years ago

We talked about this a while ago. I feel that edges that can only be in one direction should be explicitly shown to be directional, like compound -> side effect: image

Maybe there are database reasons why the direction property should be left "neutral"/undirected for these types of edges, but at least for the front end, I don't see why they shouldn't be shown as arrows.

dhimmel commented 5 years ago

I am starting to come around on this issue. We only use directed metaedges when the source and target metanode are the same, like Gene→regulates→Gene. However, users expect direction when thinking about the relationship between metanodes of different types. I'll have to do a bit of a deep dive into the hetio codebase and past records on this topic to make sure I'm accounting for all of the design decisions.