hetpandya / youtube_tts_data_generator

A python library to generate speech dataset from Youtube videos
Apache License 2.0
35 stars 8 forks source link

Webvtt dependency missing on `pip install` #5

Closed jimzers closed 3 years ago

jimzers commented 3 years ago

Lack of webvtt-py package before installing is not handled in setup.py. Added the dependency.

jimzers commented 3 years ago

4

hetpandya commented 3 years ago

Hi @jimzers, the package no longer needs webvtt-py. I shall remove the import from youtube_tts_data_generator.py The package was needed when the captions were used in vtt or srt format. Now these caption formats are converted to json and by default they are saved in json format.

jimzers commented 3 years ago

Ah, I see. Thanks for the heads up @hetpandya - closed my pull request.

hetpandya commented 3 years ago

@jimzers, I have fixed the package. Please try using pip install -U youtube-tts-data-generator

jimzers commented 3 years ago

@hetpandya Thanks - works for me!

hetpandya commented 3 years ago

Glad it worked! @jimzers