search

hetznercloud / csi-driver

Kubernetes Container Storage Interface driver for Hetzner Cloud Volumes
MIT License
620 stars 102 forks source link

fix(chart): Make default values work with cloud/dedicated hybrid clusters #539

Open WeaselScience opened 10 months ago

WeaselScience commented 10 months ago

The hcloud-csi-controller deployment has no node anti-affinity for nodes labeled with instance.hetzner.cloud/is-root-server=true by default. This means that the pod can get deployed on robot servers, rendering it useless, as it cannot access the API.

The hcloud-csi-node DaemonSet already has anti-affinity for labeled robot nodes, it should probably be added to the deployment aswell.

github-actions[bot] commented 7 months ago

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

apricote commented 7 months ago

Hey @WeaselScience,

Its not very well documented, but the controller does not need to run on Cloud Nodes if you set the HCLOUD_VOLUME_DEFAULT_LOCATION environment variable to your preferred default location. By default the controller uses the location of the Cloud Server its running on (through the metadata service), but if you configure it you can run it anywhere you like.

This is something that we should make easily configurable through the Helm Chart and change the default to be more user friendly. I will update the issue title as such.