search

hetznercloud / csi-driver

Kubernetes Container Storage Interface driver for Hetzner Cloud Volumes
MIT License
620 stars 102 forks source link

feat: truncate poll exponential backoff function to max 10s #674

Closed jooola closed 1 month ago

jooola commented 1 month ago

Related to #346 and #380

The initial exponential back off algorithm introduced in #380 was not truncated, which could lead to very long intervals. The recent release of hcloud-go truncated the default exponential back off algorithm to 60s: https://github.com/hetznercloud/hcloud-go/commit/fd1f46cc35e61dde1e524399eef88c38a757636e

If we take the scenario described in #346, I think we can still reduce the max interval value for the exponential back off algorithm to <30s.

jooola commented 1 month ago

Happy to increase the max to something between 5s and 30s

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.92%. Comparing base (8ec4683) to head (6f80195).

Files Patch % Lines
internal/app/app.go 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #674 +/- ## ========================================== - Coverage 34.01% 33.92% -0.09% ========================================== Files 19 19 Lines 1623 1627 +4 ========================================== Hits 552 552 - Misses 1037 1041 +4 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.