search

hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
695 stars 109 forks source link

feat: Event when Robot Node is removed because name changed #606

Open apricote opened 7 months ago

apricote commented 7 months ago

TL;DR

Emit Warning event when we mark a Node for removal because the Node.Name does not match RobotServer.Name

Expected behavior

We recently introduced Kubernetes Events in https://github.com/hetznercloud/hcloud-cloud-controller-manager/pull/598. I tried to identify all code-paths that should emit a warning, but missed this one. Based on the actions taken after this code path (Node is removed from cluster) I think this warrants an event to make understanding this easier for cluster operators.

https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/2f339d2c146d3a94ef184e025976d03cca674461/hcloud/instances_util.go#L92-L95

github-actions[bot] commented 4 months ago

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.