Closed simonostendorf closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.81%. Comparing base (
ed097ab
) to head (12ee38b
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the PR @simonostendorf!
Dont worry about the e2e tests
failing, they dont work for people outside of the hetznercloud
organization on GitHub.
I forgot to update the helm chart and i pushed some of my private fixes, sorry. I will fix this as soon as possible :D
This allows the
HCLOUD_TOKEN
(andROBOT_USER
andROBOT_PASSWORD
) to be read from a file. This can be useful if the token is injected using secret injection (e.g. with the vault agent injector).I tested the changes on my dev cluster. I cannot test the robot account changes, because I only use hcloud. But because they use the same function inside the code I think its working too :). If someone is interested in using this with the vault agent injector, I used the following helm values:
This change is inspired from external-dns cloudflare provider. I requested the same change for the csi-driver to keep consistency in reading HCLOUD_TOKEN from file.
Closes #595