hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
743 stars 118 forks source link

feat(helm,manifests): only specify container args instead of command #691

Closed apricote closed 4 months ago

apricote commented 4 months ago

The container image already has the entrypoint defined. It makes no sense to duplicate this in the deployment manifests.

The hardcoded entrypoint has stopped us from introducing ko for building container images before, as ko uses another entrypoint and has no option for configuring it.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.26%. Comparing base (68db213) to head (79d20bb). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #691 +/- ## ======================================= Coverage 72.26% 72.26% ======================================= Files 32 32 Lines 2668 2668 ======================================= Hits 1928 1928 Misses 552 552 Partials 188 188 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.