search

hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
740 stars 118 forks source link

feat(instance): add label to distinguish servers from Cloud and Robot #764

Closed lukasmetzner closed 3 weeks ago

lukasmetzner commented 1 month ago

This update to the HCCM introduces a new label for Kubernetes nodes: instance.hetzner.cloud/provided-by. This label will be automatically applied to nodes, indicating their origin as either:

With this features other components (e.g. csi-driver) can fine-tune their deployment requirements.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.73%. Comparing base (41a0a39) to head (32e27a7). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== + Coverage 70.67% 70.73% +0.05% ========================================== Files 31 31 Lines 3182 3188 +6 ========================================== + Hits 2249 2255 +6 Misses 760 760 Partials 173 173 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jooola commented 1 month ago

The title of the PR is confusing, in our context, a server type might be for example cx22.