search

hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
743 stars 118 forks source link

feat(load-balancer): Set IPMode to "Proxy" if load balancer is configured to use proxy protocol (#727) #783

Closed lukasmetzner closed 2 weeks ago

lukasmetzner commented 2 weeks ago

KEP-1860 introduced a new field service.status.loadBalancer.ingress[].ipMode: VIP | Proxy to indicate the behavior of the Load Balancer.

Currently users on IPVS-based networking setups can not access the Load Balancer IPs when they enable PROXY protocol. Expected behavior

Users should always be able to access their services from inside of the cluster, even if they use IPVS and PROXY protocol.

IIUC we should set the IP Mode to Proxy for the IPs we return in the status.

lukasmetzner commented 2 weeks ago

As Kubernetes version 1.28 is no longer supported we can skip the version check.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (044c7a2) to head (83fab0d). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/load_balancers.go 86.66% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #783 +/- ## ========================================== + Coverage 70.29% 70.41% +0.11% ========================================== Files 31 31 Lines 3205 3231 +26 ========================================== + Hits 2253 2275 +22 - Misses 779 782 +3 - Partials 173 174 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jooola commented 2 weeks ago

As Kubernetes version 1.28 is no longer supported we can skip the version check.

Seems like we still support it though, so we might need to drop support for 1.28 before releasing this?