search

hetznercloud / hcloud-go

A Go library for the Hetzner Cloud API
https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud
MIT License
371 stars 45 forks source link

fix(exp): configure response headers before sending them #473

Closed jooola closed 2 months ago

jooola commented 2 months ago

Ensure the headers are configured before we set the status code and send the headers.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.28%. Comparing base (baf8806) to head (7deff96).

:exclamation: Current head 7deff96 differs from pull request most recent head b05aff3

Please upload reports for the commit b05aff3 to get more accurate results.

Files Patch % Lines
hcloud/exp/mockutils/mockutils.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #473 +/- ## ========================================== - Coverage 71.31% 71.28% -0.03% ========================================== Files 45 45 Lines 3859 3862 +3 ========================================== + Hits 2752 2753 +1 - Misses 692 694 +2 Partials 415 415 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.