search

hetznercloud / hcloud-go

A Go library for the Hetzner Cloud API
https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud
MIT License
384 stars 45 forks source link

feat: add per resource list actions endpoints #521

Closed jooola closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (743eabb) to head (be3a84b).

Files Patch % Lines
hcloud/action.go 0.00% 36 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #521 +/- ## ========================================== - Coverage 71.46% 70.81% -0.65% ========================================== Files 46 46 Lines 3935 3971 +36 ========================================== Hits 2812 2812 - Misses 710 746 +36 Partials 413 413 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jooola commented 2 months ago

Closing, as it is not as useful as I thought. The actions returned by those endpoints are strictly scoped to the resource type.

e.g. one cannot query firewall apply actions that are being applied on a specific server via the /servers/<server_id>/actions endpoint. The /firewalls/actions endpoint must be queried and the result filtered client side.