Closed jooola closed 2 weeks ago
Attention: Patch coverage is 94.44444%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 68.08%. Comparing base (
9903f4d
) to head (4b6096f
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
hcloud/schema/id_or_name.go | 92.50% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Add typing information to the fields that support passing either an ID as int, an ID as string or a Name as string. An empty value will be marshalled to
null
to reflect the behavior of an empty interface.After this change, we do not have to cast IDs to float64 or to string to be able to read the values.
Since this is part of the schema package, this is not a breaking change for our customers, but might break our tests that rely on casting the interface to the desired type.