Closed ajax-ryzhyi-r closed 8 months ago
Hi @ajax-ryzhyi-r thanks for adding HCP Packer support to this plugin. The initial implementation is off to a good start but there are a few missing pieces of metadata like the source image id, used for ancestry tracking, and region data. Here's an example of all the information needed for a complete integration Linode HCP Support
We are starting the process of transferring this plugin to the Hetzner Cloud team so further reviews from may be delayed until the transfer has completed.
Hi @ajax-ryzhyi-r thanks for adding HCP Packer support to this plugin. The initial implementation is off to a good start but there are a few missing pieces of metadata like the source image id, used for ancestry tracking, and region data. Here's an example of all the information needed for a complete integration Linode HCP Support
We are starting the process of transferring this plugin to the Hetzner Cloud team so further reviews from may be delayed until the transfer has completed.
Thank you for the review! I'll add the missing pieces a little bit later 🙂
@ajax-ryzhyi-r Hey, thanks a lot for the contributions!
I accidentally closed your PR while rebasing your branch :coffee: and testing it locally. Sadly, I cannot reopen your PR. I recovered your changes and pushed them here https://github.com/hetznercloud/packer-plugin-hcloud/tree/ajax-ryzhyi-r/main
Could you reopen the PR, please? I can also open another PR with your changes, if you are ok with this?
This pull request adds support for the HCP Packer registry by including the necessary metadata in the image state. For more details see: https://developer.hashicorp.com/packer/docs/plugins/creation/hcp-support