search

hetznercloud / packer-plugin-hcloud

Packer plugin for Hetzner Cloud Builder
https://developer.hashicorp.com/packer/integrations/hetznercloud/hcloud
Mozilla Public License 2.0
22 stars 21 forks source link

feat: add labels options to server and ssh key #92

Closed janiskemper closed 7 months ago

janiskemper commented 9 months ago

Adding labels to the temporary server and ssh key objects which are needed to create the snapshot.

This is needed in some use cases where e.g. packer build stops unexpectedly due to a SIGKILL and cannot shut down properly. In order to realize that the respective server and ssh key are orphaned, labels are needed.

hashicorp-cla commented 9 months ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

janiskemper commented 9 months ago

is this something that has a chance to get merged? If so, I will continue working on it and include unit tests

nywilken commented 8 months ago

Hi @janiskemper just a heads up in the next few days we will start the process of transferring this repo out of HashiCorp to the integrations team at Hetzner Cloud. Your PR will get transferred along with the repo if not merged before then. This message is meant to just inform. Please feel free to take the time you need to get this PR ready.

janiskemper commented 8 months ago

thanks for the heads up! I am already in contact with the Hetzner team that warned me after they saw I created this PR!

jooola commented 7 months ago

Closing in favor of #128