hetznercloud / terraform-provider-hcloud

Terraform Hetzner Cloud provider
https://registry.terraform.io/providers/hetznercloud/hcloud/latest
Mozilla Public License 2.0
491 stars 71 forks source link

[Feature]: Allow hcloud_firewall.source_ips without suffix #625

Open Niecke opened 1 year ago

Niecke commented 1 year ago

What whould you like to see?

Right now, it is only possible to provide source_ips for the hcloud_firewall object in the form of 1.1.1.1/32. It would be helpful to be able to provide only the ip and skip the suffix.

I tried to give ssh access from one single server that was also created with terraform and the best solution I came up with was the following:

resource "hcloud_firewall" "master_firewall" {
  name = "master-firewall"

  rule {
    direction = "in"
    protocol  = "tcp"
    port      = "22"
    source_ips = [
      format("%s/%s",hcloud_server.management.ipv4_address,"32")
    ]
  }
}
github-actions[bot] commented 11 months ago

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

apricote commented 11 months ago

This is a useful addition and we are open to accepting PRs for this :)