Closed apricote closed 5 months ago
We have manually tested the various combinations for empty label
attributes:
null
{}
We plan to add some more detailed tests in the coming weeks, but wanted to get this fix out immediately.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.76%. Comparing base (
800a66c
) to head (f7991a3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When we implemented the Label helper we added some extra logic that handled the difference between the
label
attribute default (null) and the Hetzner Cloud API default ({}
). This worked well in our test cases, but breaks if you pass an empty object to the attribute:We have now fixed this by setting the default of the labels field to an empty object to match the return value of the API. With this, we no longer need the workaround to handle null labels in Terraform config.
Fixes #921