hetznercloud / terraform-provider-hcloud

Terraform Hetzner Cloud provider
https://registry.terraform.io/providers/hetznercloud/hcloud/latest
Mozilla Public License 2.0
479 stars 72 forks source link

fix(subnet): handle new error message for deleting subnets with attached resources #923

Closed apricote closed 2 months ago

apricote commented 2 months ago

The error message we rely on was never part of the API contract. It is soon being changed to the new message I have added. This does not fix any immediate bug, but prepares the provider for the coming months.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (800a66c) to head (5af1d40).

Files Patch % Lines
internal/network/resource_subnet.go 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #923 +/- ## ========================================== - Coverage 69.76% 69.74% -0.02% ========================================== Files 63 63 Lines 7938 7940 +2 ========================================== Hits 5538 5538 - Misses 1701 1703 +2 Partials 699 699 ``` | [Flag](https://app.codecov.io/gh/hetznercloud/terraform-provider-hcloud/pull/923/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hetznercloud) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/hetznercloud/terraform-provider-hcloud/pull/923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hetznercloud) | `69.74% <60.00%> (-0.02%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/hetznercloud/terraform-provider-hcloud/pull/923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hetznercloud) | `34.21% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hetznercloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.