hetzneronline / installimage

Bash scripts to universally deploy various distributions
Other
524 stars 142 forks source link

Confusing error message when mis-specifying image #29

Closed andrewgdotcom closed 2 years ago

andrewgdotcom commented 4 years ago

If I mistype the image name in my autosetup config file, I get a generic error with no explanation:

[15:32:09] # starting installimage on [ xxxxx ]
[15:32:09] -------------------------------------
[15:32:10] :   Hardware data:
[15:32:10] :   CPU1: AMD Ryzen 9 3900 12-Core Processor (Cores 24)
[15:32:10] :   Memory:  128769 MB
[15:32:10] :   Disk /dev/nvme0n1: 1920 GB (=> 1788 GiB) doesn't contain a valid partition table
[15:32:10] :   Disk /dev/nvme1n1: 1920 GB (=> 1788 GiB) doesn't contain a valid partition table
[15:32:10] :   Total capacity 3576 GiB with 2 Disks
[15:32:10] -------------------------------------
[15:32:10] # make clean config
[15:32:10] # executing autosetup ...
[15:32:10] # checking if the script is disabled
[15:32:10] # validating config ...
[15:32:10] :   /boot : 1024
[15:32:10] :   lvm : all
[15:32:10] :   Size of smallest drive is 1920383410176
[15:32:10] Calculated size of array is: 1920383410176
[15:32:10] checking if hdd sizes are within tolerance. min: 1920383410176 / max: 2592517603737
[15:32:10] DRIVE1 in range
[15:32:10] :   1920383410176
[15:32:10] DRIVE2 in range
[15:32:10] :   1920383410176
[15:32:10] :   check_dos_partitions
[15:32:10] # executing installfile ...
[15:32:10] :   /boot : 1024
[15:32:10] :   lvm : all
[15:32:11] => FAILED
[15:32:11] :   report install.conf to rz-admin: 1555531
[15:32:11] :   report debug.txt to rz-admin: true
[15:32:11] cleaning up

From this, it looks like the lvm configuration is at fault. It should at least say "image not found".

tomsiewert commented 4 years ago

This is a known issue and will be fixed in the near time.

asciiprod commented 2 years ago

Fixed in https://github.com/hetzneronline/installimage/commit/ba4f0cb1ca23261d48b29afeb0e1b1b82ebfe5a7