search

hetzneronline / installimage

Bash scripts to universally deploy various distributions
Other
517 stars 143 forks source link

Make installer able to handle /dev/disk/by-id/ devices #56

Closed ableischwitz closed 2 years ago

ableischwitz commented 2 years ago

This change introduces the detection of DRIVEn /dev/disk/by-id/xxxx devices. Additionally to the different nvme naming for partitions, those disks get a -partx added to the device - instead of a single number

Currently the installer simply adds a "1", "2",... to the device - which is fine for /dev/sda, /dev/sdb, - there is already a exception for nvme devices, which also needs to be implemented for `/dev/disk/by-id/devices. Not having this ability to provide static device names renders the installer to become unpredictable with 3 drives if only two of them should be configured. This change also allows devices to be listed with theirwwm-0x5xxxxname as they also reside in/dev/disk/by-id`.

ableischwitz commented 2 years ago

With further testing, I found that the changes made, are not enough.

guettli commented 1 year ago

Sad to hear that this was closed. Is there an alternative solution to use wwn/uuid in installimage?

func0der commented 9 months ago

@ableischwitz What else is not working? These are similar findings to what I have found out. The only thing broken for me seem to be the raid, which was relying on the partition id in the end of /dev/sdaX.

Could you elaborate?

ableischwitz commented 9 months ago

@func0der I stopped following up on this as I solved that issue by running an ansible-playbook which identifies the devices and adjusts the install-config accordingly. Due to the different naming for MD/NVME/* devices, the script may need some further adjustment to deal with all the special cases.

func0der commented 9 months ago

@func0der I stopped following up on this as I solved that issue by running an ansible-playbook which identifies the devices and adjusts the install-config accordingly. Due to the different naming for MD/NVME/* devices, the script may need some further adjustment to deal with all the special cases.

Thanks for getting back to me. I think I have addressed all the places here: https://github.com/hetzneronline/installimage/pull/92

If you have time and want to have a look at it, a :+1: might help to get it merged :)