search

hetzneronline / installimage

Bash scripts to universally deploy various distributions
Other
517 stars 143 forks source link

Add support for /dev/disk/by-id/.... notation in config #92

Closed func0der closed 4 months ago

func0der commented 9 months ago

Replaces https://github.com/hetzneronline/installimage/pull/56 Relates to https://github.com/hetzneronline/installimage/issues/30

Couple of remarks: This script has multiple places where drives and partitions are handled. Almost all of them need to be aware of the correct notation of partitions. I think, that most of the time it is just a lucky hit, that it works. Also the part where it either uses p (nvme) or -part is in there at least twice, so parts of that script have been compatible with the by-id notation already.

I do not feel comfortable doing that kind of refactoring, though. Just wanted to mention that it might be a good idea to pull partition detection by name (or something) together some place.

Either way, I think this is a good start.

func0der commented 9 months ago

@asciiprod LGTM? :)

func0der commented 7 months ago

Hello?

asciiprod commented 4 months ago

There was another place which had to be adjusted, but in general it should work now.

func0der commented 4 months ago

Thanks for merging.

I just realized that I forgot to tick 'allow edits by maintainer' and wondered why the PR was not merged but rather the contents copied.

Anyway: Glad the repo is alive and this feature made it in