heuer / sdshare-tests

SDShare test suite
Apache License 2.0
3 stars 1 forks source link

Apparent false negative in TestFragmentFeed.testFragmentFeed #3

Closed larsga closed 14 years ago

larsga commented 14 years ago

The first assert in TestFragmentFeed.testFragmentFeed fails on

Fragments feed for beer.xtm 2010-10-21T09:14:28Z Ontopia SDshare server file:/Users/larsga/data/topicmaps/beer.xtm/fragments sdshare:ServerSrcLocatorPrefixfile:/Users/larsga/data/topicmaps/beer.xtm/sdshare:ServerSrcLocatorPrefix

At least I assume this is the feed it fails on. It's difficult to say for certain from the error message.

larsga commented 14 years ago

Sorry for the formatting error. Second attempt:

<feed xmlns="http://www.w3.org/2005/Atom" xmlns:sdshare="http://www.egovpt.org/sdshare">
  <title>Fragments feed for beer.xtm</title>
  <updated>2010-10-21T09:14:28Z</updated>
  <author>
    <name>Ontopia SDshare server</name>
  </author>
  <id>file:/Users/larsga/data/topicmaps/beer.xtm/fragments</id>
  <sdshare:ServerSrcLocatorPrefix>file:/Users/larsga/data/topicmaps/beer.xtm</sdshare:ServerSrcLocatorPrefix>
</feed>
heuer commented 14 years ago

The feed seems to be valid. Maybe an unexpected status code / media type is returned from the server? Please retry the tests with the changes made in 994b464d5f8352b5cb2353407131f23dee80eab4

larsga commented 14 years ago

Still fails:

1) testFragmentFeed0 java.lang.AssertionError: Expected one sd:ServerSrcLocatorPrefix expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.failNotEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:126) at org.junit.Assert.assertEquals(Assert.java:470) at org.isotopicmaps.sdsharetests.server.TestFragmentsFeed.testFragmentFeed(TestFragmentsFeed.java:72)

larsga commented 14 years ago

Argh: "1 but was: 0".

heuer commented 14 years ago

I think the test is correct. Your SDShare namespace is bound to "http://www.egovpt.org/sdshare" and not to "http://www.egovpt.org/sdshare/" (trailing slash missing)

heuer commented 14 years ago

Sorry. The trailing slash is wrong. Your ns decl. is correct. I'll fix it

heuer commented 14 years ago

Fixed in aa0bbfba455c3142c12c