Use class_list_macros.hpp instead of deprecated .h

heuristicus / spot_ros

ROS driver for controlling Boston Dynamics' Spot robot

https://heuristicus.github.io/spot_ros/

Other

268 stars 136 forks source link

Use class_list_macros.hpp instead of deprecated .h #149

Closed lucasw closed 2 months ago

lucasw commented 2 months ago

The .h is removed entirely in pluginlib-dev in newer ubuntu/debian versions (https://packages.debian.org/bookworm/all/pluginlib-dev/filelist)

heuristicus commented 2 months ago

From what I can tell, the default pluginlib version in ubuntu 20.04 is 1.12.1-3m which appears to have the .h headers as well as .hpp. 20.04 is the last version this driver will support, so that's fine. I suppose debian has more up to date packages?

lucasw commented 2 months ago

Yeah the older debian bullseye is probably in line with 20.04, it has the .h files (which are just thin wrappers around the hpp files). The hpp files have been around for years so there should be no issue with using these changes with noetic (or perhaps even much older versions). I'm using Ubuntu 23.10, it and 22.04 don't have the .h files so those must be more or less synced with debian bookworm.