search

heuristicus / spot_ros

ROS driver for controlling Boston Dynamics' Spot robot
https://heuristicus.github.io/spot_ros/
Other
273 stars 140 forks source link

Instructions for Using `cakin build` for Python3 Work-Around on Melodic #48

Open MarioGini opened 2 years ago

MarioGini commented 2 years ago

As the description says, the build instructions suggest to use catkin_make when using the python3 workaround for ROS Melodic. I think that in general, using catkin build is preferred over catkin_make so maybe that section could suggest to e.g. add the additional CMake arguments to a caktin config profile using catkin config --cmake-args ...

civerachb-cpr commented 2 years ago

Realistically you can use either tool, and both will do the job of building the packages. We tend to use catkin_make in a lot of our examples as that command is automatically included (and is also what the ROS wiki uses in its tutorials).

I don't know that there would be a lot of benefit to adding the catkin build instructions when the provided instructions using catkin_make do work on Melodic. Melodic is in an awkward situation, since it exists after the Python3 EOL date, but is still stuck without official Python3 support and is stuck requiring these sorts of work-arounds.

peci1 commented 2 years ago

catkin_make is the official Melodic tool for building packages. catkin build is an alternative implementation. I think it's good the tutorials stick with the officially distributed build system.

civerachb-cpr commented 2 years ago

I've edited the title of this issue. Anyone preferring to use catkin build can find this issue and use the instructions you've provided here, rather than modifying our core instructions to use a secondary build system.

BADAL244 commented 2 years ago

/home/agx3/ros2/devel/include/spot_msgs/LeaseArray.h:18:10: fatal error: spot_msgs/LeaseResource.h: No such file or directory

include <spot_msgs/LeaseResource.h>

      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
civerachb-cpr commented 2 years ago

This driver is for ROS1 (specifically Melodic and Noetic). The path to the file seems to indicate you're trying to use the driver for ROS2?