search

hevelius / files_external_onedrive

:mega: :floppy_disk: External storage support for Microsoft OneDrive
GNU General Public License v2.0
72 stars 22 forks source link

Link drops after 1 hour #36

Open PadrinoGT92 opened 4 years ago

PadrinoGT92 commented 4 years ago

Nextcloud 16.0.10.

After authing and following guide to setup I can access my onedrive. But after 1 hour the connection drops and I have to resetup the external storage.

Please advise a workaround or fix?

hevelius commented 4 years ago

What engine/version of DB, OS? Have you some errors in logs?

hevelius commented 4 years ago

The plugin on NC 17 and later not works properly during the token refresh background job. I'll try to find a solution as soon as possible.

martinlentink commented 4 years ago

The plugin on NC 17 and later not works properly during the token refresh background job. I'll try to find a solution as soon as possible.

Hi Hevelius, thank you very much for addressing this. Perhaps a bit more info from my side: I've followed your guide to install and setup, after which the plugin works as advertised, ie I can copy file to and from the users Onedrive. When I leave the mounted directory however, a bit later it is no longer accessible. Our nextcloud instance is relatively small ( <20 users) and so I rely on the ajax to perform background jobs. Could that have something to do with it? Should I set up cron to handle background jobs? I guess you're handling tokens etc. in the backgound, but perhaps not by NC itself but by your own? Anyway, please let us know if you need more info aof for us to try stuff.

Martin

hevelius commented 4 years ago

Hi @martinlentink, the token refresh procedure happens in background by NC. To do this I add a background job to files_external_onedrive as described here.

The background job is fired by cron event in NC. If cron is not activated in NC the token is not updated.

M.

martinlentink commented 4 years ago

Hi Marco, Sorry it took me so long, had to take care of a few other issues. I have a bit more time on my hands now and would like to see if I can help getting this app rolling again, if you still want to do so. Currently I am on NC 19.0.1 (Stable channel) with background jobs refreshed by cron every 5 minutes. I have made a dedicated subdirectory as a mountpoint for the app in my own NC-folder. Then I followed your instructions for setting up in the Azure portal which resulted in a client-ID and client-secret (each step done carefully to avoid errors and typos, see screenshot1). Then went to NC (settngs/user/externalstorages) and entered the data for a hew external storage of type Onedrive with the created mountpoint. Then clicked on Grant Access and was led throught the OAuth process, which seemed to conclude successfully. But when I returned to NC I could not use the Onedrive (screenshot2) and when I go to files and try to open the storage it gives me and error message (screenshot3). What would you like to see to troubleshoot this? Anything you would want me to try?

Thanks in advance!

Martin

Screenshot1 Screenshot2 Screenshot3

martinlentink commented 4 years ago

Just saw that pull request submitted by feurigel 3 days ago, which might be related to what I'm experiencing. Sometimes I regret not being a programmer. Hope you can find the time to take a look at it. Thanks in advance!