Fix oauth2 access: invalid_client_secret

hevelius / files_external_onedrive

:mega: :floppy_disk: External storage support for Microsoft OneDrive

GNU General Public License v2.0

72 stars 22 forks source link

Fix oauth2 access: invalid_client_secret #39

Closed feurigel closed 3 years ago

feurigel commented 4 years ago

This commits fixes "invalid_client_secret".

The problem was:

With commit (nextcloud/server@0d112d7#diff-8b87ec33b8bfb6e79af3a46d287408d2) the clientsecret was rewrite after reload (or backlink from oauth2) to "\_unmodified__"
To fix this behavior this commit saves client_secret temporary in localstorage
After reading from localstorage the client_secret would be deleted

Additionally:

If an user selects onedrive and dropbox or google drive: The plugins overwritten each other's events.

JamesDAdams commented 3 years ago

when will the merger on develop ?

feurigel commented 3 years ago

Sorry, I didn't see that a develop branch exists. I changed the pull request to branch develop.

JamesDAdams commented 3 years ago

I don't no if is Master or develop i'm juste a user and i try to use files_external_onedrive but it's doesn't work :(

feurigel commented 3 years ago

I don't no if is Master or develop i'm juste a user and i try to use files_external_onedrive but it's doesn't work :(

You need to install this plugin manually from here: https://github.com/feurigel/files_external_onedrive/tree/fix-oauth2-access

Use git clone or download functionality. Warning! The README url is not up-to-date in this repository. And this plugin doesn't work with Nextcloud 19.

This pull request fixes only #33.