App causes invalid signature errors after installation.

zetix commented 3 years ago

After installing External Storage: OneDrive, you cannot install any other app. The error message you'll get is:

App with id [app name] has invalid signature

Posts with this issue:

Error log downloading OneDrive integration as an example:

[settings] Error: Exception: App with id integration_onedrive has invalid signature at <<closure>>

0. /snap/nextcloud/24940/htdocs/apps/settings/lib/Controller/AppSettingsController.php line 445
   OC\Installer->downloadApp("integration_onedrive")
1. /snap/nextcloud/24940/htdocs/lib/private/AppFramework/Http/Dispatcher.php line 169
   OCA\Settings\Controller\AppSettingsController->enableApps(["integration_onedrive"], [])
2. /snap/nextcloud/24940/htdocs/lib/private/AppFramework/Http/Dispatcher.php line 100
   OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings\Con ... {}, "enableApps")
3. /snap/nextcloud/24940/htdocs/lib/private/AppFramework/App.php line 152
   OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings\Con ... {}, "enableApps")
4. /snap/nextcloud/24940/htdocs/lib/private/Route/Router.php line 308
   OC\AppFramework\App::main("OCA\\Settings\\ ... r", "enableApps", OC\AppFramework\ ... {}, {action: null,_r ... "})
5. /snap/nextcloud/24940/htdocs/lib/base.php line 1008
   OC\Route\Router->match("/settings/apps/enable")
6. /snap/nextcloud/24940/htdocs/index.php line 37
   OC::handleRequest()

POST /index.php/settings/apps/enable

thekarinka commented 3 years ago

I can confirm this issue. As workaround is disabling onedrive app, update other apps and after enable onedrive app.

nunesgh commented 3 years ago

I have also experienced this issue (https://github.com/nextcloud/files_antivirus/issues/182 and https://github.com/nextcloud/guests/issues/522) and I can confirm @thekarinka's workaround solves this.

Does anyone know why this is happening?

hevelius commented 3 years ago

Hi guys,

@ZetiX in your logs the app id integration_onedrive belongs to another app. This -> https://apps.nextcloud.com/apps/integration_onedrive. It's not files_external_onedrive. During the tests I did not encounter the same problem. I suppose the workaround proposed by @thekarinka solves.

And remember integration_onedrive is not files_external_onedrive.

KnudH commented 3 years ago

integration_onedrive does not encounter the bug, it is the files_external_onedrive app. I never installed the integration but having the same issue with the files_external_onedrive app.

So pls reopen, as long as the bug is not solved.

zetix commented 3 years ago

@hevelius As I mention in the post, I'm only using the OneDrive integration as an example as the error produced is the same for any other app you're trying to install with files_external_onedrive app enabled.

It's not really a huge issue as it's not like admins on nextcloud are installing and removing apps daily and if needed, disabling files_external_onedrive would resolve the issue.

The problem is that some users aren't aware that files_external_onedrive is the culprit and would go down a rabbit hole trying to solve it. If they aren't able to find a fix, the only other solution would be to do a complete reinstall. It would be great if you add the possibility of this issue occurring as a note to the app description if you are unable to encounter the same problem.

hevelius commented 3 years ago

Interesting discussion. Before reopen this issue please tell me

O.S.
Configuration: e.g. apache/nginx php version
NC version
which other apps you have enabled

so I can do more tests replicating your same issue.

zetix commented 3 years ago

OS: Ubuntu 20.04 Server

Snap Nextcloud info: Nextcloud 20.0.4 Apache 2.4 PHP 7.3 MySQL 5.7 Redis 5.0

Apps:

Enabled:
  - accessibility: 1.6.0
  - activity: 2.13.4
  - bruteforcesettings: 2.0.1
  - cloud_federation_api: 1.3.0
  - comments: 1.10.0
  - contacts: 3.4.2
  - contactsinteraction: 1.1.0
  - dav: 1.16.2
  - duplicatefinder: 0.0.4
  - epubreader: 1.4.5
  - federatedfilesharing: 1.10.2
  - files: 1.15.0
  - files_downloadactivity: 1.9.0
  - files_external: 1.11.1
  - files_pdfviewer: 2.0.1
  - files_retention: 1.9.0
  - files_rightclick: 0.17.0
  - files_sharing: 1.12.1
  - files_trashbin: 1.10.1
  - files_versions: 1.13.0
  - files_videoplayer: 1.9.0
  - firstrunwizard: 2.9.0
  - keeweb: 0.6.4
  - logreader: 2.5.0
  - lookup_server_connector: 1.8.0
  - maps: 0.1.8
  - metadata: 0.12.0
  - notifications: 2.8.0
  - oauth2: 1.8.0
  - password_policy: 1.10.1
  - photos: 1.2.1
  - privacy: 1.4.0
  - provisioning_api: 1.10.0
  - quickaccesssorting: 1.1.2
  - recommendations: 0.8.0
  - serverinfo: 1.10.0
  - settings: 1.2.0
  - sharebymail: 1.10.0
  - side_menu: 1.21.0
  - socialsharing_email: 2.1.0
  - suspicious_login: 3.2.1
  - systemtags: 1.10.0
  - text: 3.1.0
  - theming: 1.11.0
  - twofactor_admin: 3.0.0
  - twofactor_backupcodes: 1.9.0
  - twofactor_nextcloud_notification: 3.1.0
  - twofactor_totp: 5.0.0
  - user_status: 1.0.1
  - viewer: 1.4.0
  - weather_status: 1.0.0
  - workflowengine: 2.2.0

However, based on the posts and threads on other forums regarding this topic, it also occurs on docker and manual installations as well, though I do not have the complete details of their configuration.

nunesgh commented 3 years ago

The problem is that some users aren't aware that files_external_onedrive is the culprit and would go down a rabbit hole trying to solve it. If they aren't able to find a fix, the only other solution would be to do a complete reinstall.

Exactly! If I did not find this issue here (thank you @ZetiX, by the way), the next step would be exactly to do a complete reinstall.

As I have mentioned above, I had signature errors with two other apps and even bothered to open issues on their respective repos (https://github.com/nextcloud/files_antivirus/issues/182 and https://github.com/nextcloud/guests/issues/522).

But what really solved those errors was to remove files_external_onedrive --not integration_onedrive, which wasn't even installed.

Here is my server configuration as well:

Operating system: Debian 10
Web server: Apache 2
Database: MySQL 19.0.3.1
PHP version: 7.3
Nextcloud version: 20.0.4
Where did you install Nextcloud from: Website tarball.

And here are the errors caused by the presence of files_external_onedrive:

files_antivirus

{"reqId":"zsPMu3HIEj0QYEr5J9VJ","level":3,"time":"2020-12-22T10:37:23+00:00","remoteAddr":"***sensitive parameters replaced***","user":"***sensitive parameters replaced***","app":"core","method":"GET","url":"/settings/apps/update/files_antivirus","message":{"Exception":"Exception","Message":"App with id files_antivirus has invalid signature","Code":0,"Trace":[{"file":"/***sensitive parameters replaced***/nextcloud/lib/private/Installer.php","line":198,"function":"downloadApp","class":"OC\\Installer","type":"->","args":["***sensitive parameter replaced***",false]},{"file":"/***sensitive parameters replaced***/nextcloud/apps/settings/lib/Controller/AppSettingsController.php","line":532,"function":"updateAppstoreApp","class":"OC\\Installer","type":"->","args":["***sensitive parameters replaced***"]},{"file":"/***sensitive parameters replaced***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"updateApp","class":"OCA\\Settings\\Controller\\AppSettingsController","type":"->","args":["***sensitive parameters replaced***"]},{"file":"/***sensitive parameters replaced***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"updateApp"]},{"file":"/***sensitive parameters replaced***/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"updateApp"]},{"file":"/***sensitive parameters replaced***/nextcloud/lib/private/Route/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Settings\\Controller\\AppSettingsController","updateApp",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"appId":"***sensitive parameter replaced***","_route":"settings.AppSettings.updateApp"}]},{"file":"/***sensitive parameters replaced***/nextcloud/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/settings/apps/update/files_antivirus"]},{"file":"/***sensitive parameters replaced***/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/***sensitive parameters replaced***/nextcloud/lib/private/Installer.php","Line":367,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0","version":"20.0.4.0","id":"***sensitive parameters replaced***"}

guests

{"reqId":"CdKHQHBTKhebpoIP9La8","level":3,"time":"2020-12-22T10:37:25+00:00","remoteAddr":"***sensitive parameter replaced***","user":"***sensitive parameter replaced***","app":"core","method":"GET","url":"/settings/apps/update/guests","message":{"Exception":"Exception","Message":"App` with id guests has invalid signature","Code":0,"Trace":[{"file":"/***sensitive parameter replaced***/nextcloud/lib/private/Installer.php","line":198,"function":"downloadApp","class":"OC\\Installer","type":"->","args":["***sensitive parameter replaced***",false]},{"file":"/***sensitive parameter replaced***/nextcloud/apps/settings/lib/Controller/AppSettingsController.php","line":532,"function":"updateAppstoreApp","class":"OC\\Installer","type":"->","args":["***sensitive parameters replaced***"]},{"file":"/***sensitive parameter replaced***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":169,"function":"updateApp","class":"OCA\\Settings\\Controller\\AppSettingsController","type":"->","args":["***sensitive parameters replaced***"]},{"file":"/***sensitive parameter replaced***/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":100,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"updateApp"]},{"file":"/***sensitive parameter replaced***/nextcloud/lib/private/AppFramework/App.php","line":152,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"updateApp"]},{"file":"/***sensitive parameter replaced***/nextcloud/lib/private/Route/Router.php","line":308,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Settings\\Controller\\AppSettingsController","updateApp",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"action":null,"appId":"***sensitive parameter replaced***","_route":"settings.AppSettings.updateApp"}]},{"file":"/***sensitive parameter replaced***/nextcloud/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/settings/apps/update/guests"]},{"file":"/***sensitive parameter replaced***/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/***sensitive parameter replaced***/nextcloud/lib/private/Installer.php","Line":367,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0","version":"20.0.4.0","id":"***sensitive parameter replaced***"}

hevelius commented 3 years ago

Ok guys, I have replicated the issue and I'm working on a solution to resolve. Issue repoened. Thanks for testing.

hevelius / files_external_onedrive

App causes invalid signature errors after installation. #46