Dev9, SkyrimSE, BSDismemberSkinInstance to NiSkinInstance

Meridiano commented 5 months ago

BSDismemberSkinInstance to NiSkinInstance conversion doesn't work in Dev9 for SkyrimSE meshes.

Steps to reproduce:

right mouse button on BSDismemberSkinInstance
Block > Convert > NiS... > NiSkinInstance // here you can see block changes but block content does not
File > Save // nothing happens, file is not saved
File > Save As... > Save with a different filename
File > Reload // here come errors

Parsing warnings: NiSkin Data [6]\Bone List, updateArraySize Impl: Array size -2147483648 is invalid.

The NIF file could not be read. See Details for more information. Pos 1003: failed to load block number 6 (NiSkinData) pre vious block was NiSkinInstance Failed to load C:/Users/User/Desktop/silverring_1_mod.nif

2 related meshes attached. 1st is original, 2nd is processed and saved. SilverRing_1.zip

fo76utils commented 5 months ago

Fixed by this commit. A previous commit on July 30, 2023 made a change so that the name of the original block type (btype) is only stored by reference instead of copying it to a new string, but this breaks the code a few lines below. I reverted to making a copy.

gavrant commented 2 weeks ago

@fo76utils I wonder how many other bugs you, guys, have found in my "carpet bombing" refactors from 2023?

hexabits / nifskope

Dev9, SkyrimSE, BSDismemberSkinInstance to NiSkinInstance #74