Embedded media support - Githubissues

fnc commented 7 years ago

New feature as requested in issue #16.

Server:

new operation for Open graph data scraping.

Web:

new react component for embedding media.

pomber commented 7 years ago

Awesome!
Some comments:

Can you make the videos to not autoplay?
The username is dropping to below the avatar:

fnc commented 7 years ago

Sure, i will check this

fnc commented 7 years ago

Youtube videos were working fine, i fixed twitter videos.

pomber commented 7 years ago

Looks great! Two more requests:

Could you add more padding between the media and the text?

Can you check why is this showing when entering from an url like http://localhost:3000/realdonaldtrump?

warning.js:36 Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the EmbeddedMedia component.
printWarning @ warning.js:36
warning @ warning.js:60
getInternalInstanceReadyForUpdate @ ReactUpdateQueue.js:48
enqueueSetState @ ReactUpdateQueue.js:200
ReactComponent.setState @ ReactComponent.js:63
EmbeddedMedia._this.handleError @ EmbeddedMedia.js:30

hexacta / sanata

Embedded media support #29