hexagon-oss / openhardwaremonitor

Open Hardware Monitor - a tool for monitoring hardware performance. Includes support for various temperature sensors, disk I/O ratings and power consumption.
Mozilla Public License 2.0
191 stars 24 forks source link

Update IntelCPU.cs #40

Closed gym404 closed 2 years ago

gym404 commented 2 years ago

Adding fammily 0x9A (Intel Core 12th 0x97 is only the Desktop version, Mobile CPU is 0x9A). After the modification, the mobile Adder Lake temperature value is displayed correctly.

image

pgrawehr commented 2 years ago

Thanks for the fix

tobes08 commented 1 year ago

Sorry, very new to github. Im looking to download openhardware for alder lake cpu's and have cpu temps. I believe gym404 has made that possible but im having trouble actually downloading the updated file or editing the file using github ( i really dont know how github works :/). Ive downloaded the master zip file and can see the comment made about adding intel 12th mobile cpu's(hardware->CPU->IntelCPU), however, l cant get openhardware to run. Any help is appreciated.

pgrawehr commented 1 year ago

@tobes08 What do you mean by "Can't get to run"? What did you try? Did you get any error messages?

tobes08 commented 1 year ago

ok, so l cant find a .exe file to click All the files are about 2kb. just to clarify, ive downloaded and unzipped the file called 'openhardwaremonitor-master'. Essentially, what im asking is, where do l go from here? Am l on the wrong track? image

pgrawehr commented 1 year ago

@tobes08 Oh, I see. You have downloaded the source then. In that case, you need to build the code yourself (there's no binary release yet that includes this change).

Run the build.cmd script in the root folder (after extracting the zip). But that will only work if you have a build environment (such as Visual Studio) installed. Oh, and you seem to have an archive that doesn't really match master. Consider directly checking out using git. If that sounds like greek to you, it's probably not the way to go, as there's quite some background required to master all of this.

I have some open issues before I'll build a new binary release, but I'm uncertain when I find time for that unfortunately.

tobes08 commented 1 year ago

Ok, this is making sense where lm confused. I appreciate your time. I've conducted a bit of research with your information and just need a bit of guidance if lm correct.

  1. lll start by completing the four steps in the link: https://github.com/dotnet/msbuild/issues/3937
  2. From there it should be fairly intuitive? What lm confused about in your comment relates to the archive that doesnt match master. I can resolve this issue by 'Checking out using git' which is indeed greek to me ahaha. If you reckon this will be too hard for me, let me know. Otherwise, ill save ourselves time by using gpu temps which is already given.

update: ok so i think ive done the 'git checkout' like u said by navigating to code(top right of the github interface)->checkout with github desktop->open in VSC

ill see where l get up to.

pgrawehr commented 1 year ago

@tobes08 I found where you ended up. You've downloaded the (unmaintained) older version. Download the zip file from here: https://github.com/hexagon-oss/openhardwaremonitor (with the green down-arrow button). If you extract that, you should have a "build.cmd" file in the root directory.

tobes08 commented 1 year ago

:( build failed. not sure if l attampted it correctly though. When l tried to 'run' build.cmd, VSC recommended to download an extension called 'Batch Runner'. However this produced 4 warnings and 2 errors in the terminal. l can copy these errors or warnings upon request. if there is any youtube video i should watch, please link. image

pgrawehr commented 1 year ago

That error message is apparently because you downloaded the zip file from an "untrusted" source (internet). I have never seen this before, but you'll probably get a hint on how to avoid this problem here: https://learn.microsoft.com/en-us/visualstudio/ide/reference/trust-settings?view=vs-2022

gym404 commented 1 year ago

You can download an already builder version from the  following link:Release Version 0.10.3-alpha1 · hexagon-oss/openhardwaremonitorgithub.comOn 2022. Dec 21., at 13:57, tobes08 @.***> wrote: ok, so l cant find a .exe file to click

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

pgrawehr commented 1 year ago

@gym404 That won't work for him, because he needs a fix that's not yet in the latest release.

tobes08 commented 1 year ago

Correct. That link (from pgrawehr) you sent was for Visual Studio (Im using VSC but can try switch tomorrow). However, using that link l was able to ensure that the files i was using was trusted by following the youtube video : https://www.youtube.com/watch?v=1nePPW6Xx7A&ab_channel=Code2020

Ill spend a bit more time on this right now, trying to understand the errors codes. otherwise, ill try visual studio tomorrow and update you guys. Again, cheers for your time guys, l mean that a lot. its 2am where im at

tobes08 commented 1 year ago

cheers @pgrawehr and @gym404 for taking the time to help me. finally got it to work after unblocking the files causing errors image