search

hexagon5un / AVR-Programming

Code examples for the book "Make: AVR Programming"
http://littlehacks.org/AVR-Programming
MIT License
755 stars 340 forks source link

Unused makefile definitions #7

Closed sf1 closed 9 years ago

sf1 commented 10 years ago

Hi, first of all thanks for this awesome resource. I just had a look at the chapter 2 makefile and I noticed there are two variable definitions that are never used in any of the rules:

##List of all header files
HEADERS = $(SRC:.c=.h) 

##For every .c file, compile an .o object file
OBJ = $(SRC:.c=.o)

Probably remnants from an earlier version?

hexagon5un commented 10 years ago

Hi,

Yeah. I really need to go over the Makefile again with a fine-tooth comb. (Or just repackage one of the standard ones.)

There may be some stuff in there that are left over from an over-optimized version that I was using to get the absolute-smallest code size for some old projects.

Thanks for the push. I'll get on it soon.

 Elliot.

On 14-09-24 21:21:33, Sebastian Fleissner - notifications@github.com wrote:

Hi, first of all thanks for this awesome resource. I just had a look at the chapter 2 makefile and I noticed that there are two variable definitions that are never used in any of the rules:

List of all header files

HEADERS = $(SRC:.c=.h)

For every .c file, compile an .o object file

OBJ = $(SRC:.c=.o)

Probably remnants from an earlier version?

Reply to this email directly or view it on GitHub: https://github.com/hexagon5un/AVR-Programming/issues/7

hexagon5un commented 9 years ago

Heya,

I finally got around to re-writing (minor bits of) the Makefile, and it's much more "normal" now.

All better.