hexatester / rosrestpy

RouterOS v7 REST API python module
GNU General Public License v3.0
27 stars 5 forks source link

Enhancements #1

Open Icosa-Consulting opened 10 months ago

Icosa-Consulting commented 10 months ago

Hello,

I'm submitting this pull request for the enhanced logging and error trapping I've implemented. I've added logging to the HTTP requests in ROS namely [get,patch,delete,etc]_as() as well as some error trapping. The requests library also had the handy method response.raise_for_status() to raise some HTTP errors automatically which I added during the logging phase.

I added a delete_as() method since the session.delete you were using wasn't getting the URL from the ROS class, self.url was just blank and was causing some exceptions and self.filename only had the API portion of the call.

The readme shows some of the basic logging that can be done outside of the internal logging.

Icosa.