search

hexawyz / NetUnicodeInfo

Unicode Character Inspector & Library providing a subset of the Unicode data for .NET clients.
https://www.nuget.org/packages/UnicodeInformation/
MIT License
59 stars 11 forks source link

handle incomplete reads #7

Closed adamsitnik closed 3 years ago

adamsitnik commented 3 years ago

.NET 6 has introduced a breaking change for handling incomplete reads from DeflateStream. This was discovered in https://github.com/dotnet/runtime/issues/54538.

Please see https://github.com/dotnet/docs/issues/24649 for more details

hexawyz commented 3 years ago

Hi,

Thanks for the fix! I certainly never expected that behavior from an in-memory stream, but I guess it makes sense somehow 😅

adamsitnik commented 3 years ago

@GoldenCrystal Thank you for merging it so quickly!

I certainly never expected that behavior from an in-memory stream, but I guess it makes sense somehow

I've learned it the hard way that if Read returns an int there is a chance for incomplete read.

May I ask when do you plan to release a new package version to nuget.org? We hope that .NET 6 is soon going to become popular and would expect all users to hit this problem ;)

hexawyz commented 3 years ago

Apparently I needed to fix problems with the CI, but it seems to be all good now 🙂 I published the new package with your fixes. Thanks again ^^