search

hexdae / toolchains_arm_gnu

ARM embedded toolchains for Bazel
https://asnaghi.me/post/embedded-bazel/
MIT License
104 stars 35 forks source link

Adds aarch64_none_linux_gnu support #49

Closed makestuffwork closed 6 months ago

makestuffwork commented 6 months ago

This is a straightforward adding aarch64_none_linux_gnu following the existing scheme. There seems to be some unnecessary formatting rearrangements. Those are automatically done by the bazel style formatter embedded in my editor. I have good confidence in what it's doing.

hexdae commented 6 months ago

Sorry, I added aarch64-none-elf recently to complement this and caused some conflicts, let me know if you want me to fix them or if you can rebase

makestuffwork commented 6 months ago

Sorry, I added aarch64-none-elf recently to complement this and caused some conflicts, let me know if you want me to fix them or if you can rebase

I rebased from your HEAD.

This is great, do you mind adding a test in test/aarch64-none-linux-gnu if it's too much work, we can merge and I will add it later

Sorry, I'm really not skillful at adding this test. I did test it with my own project at https://github.com/google/pcie_lmt/blob/06ff42cb8724f75cd5fd6e081b03b3df3e42d2a3/BUILD#L60

hexdae commented 6 months ago

This should be ready to go, thanks a lot for adding it. I am going to release soon