search

hexenq / kuroshiro

Japanese language library for converting Japanese sentence to Hiragana, Katakana or Romaji with furigana and okurigana modes supported.
https://kuroshiro.org
MIT License
781 stars 88 forks source link

Add types #93

Open ALOHACREPES345 opened 2 years ago

ALOHACREPES345 commented 2 years ago

Thank you for creating nice library. I'm trying to use this library for my TypeScript project, but it needs declaration (.d.ts) file.

I saw below issue, but nobody has dealt with it, so I added. https://github.com/hexenq/kuroshiro/issues/48

Also, please refer to this pull request. https://github.com/hexenq/kuroshiro-analyzer-kuromoji/pull/7 If "kuroshiro" user uses "kuroshiro-analyzer-kuromoji", needs types as well.

Thank you.

yusuftaufiq commented 1 year ago

This is great PR, but it seems the repository owner has been inactive for a while. Can this PR be opened to DefinitelyTyped instead?

lcsvcn commented 3 days ago

when this PR will be merged?