search

hexgnu / linkedin

Ruby wrapper for the LinkedIn API
http://rdoc.info/gems/linkedin
MIT License
759 stars 407 forks source link

Faraday connection updated #248

Open hundredwatt opened 9 years ago

hundredwatt commented 9 years ago

@hexgnu I came back and took another look at this. I rebased #212 onto master and made a few fixes. The only notable change is adding the :ignore_extra_keys which fixes SimpleOAuth v0.3.0.

How about targeting and #211 this for a 1.1.0 release? I'm going to work on #211 next

Also, I'm going to run this branch in one of our apps for a couple days to verify that its good to go.

Regarding #240, I'm happy to start reviewing the existing PRs and issues and enlisted some other developers here to help (@GaggleAMP) if necessary.

hundredwatt commented 9 years ago

@hexgnu I've been running this branch in a production app for a few days with no issues.

Only remaining problem is the build failing on rbx

hexgnu commented 9 years ago

Maybe we should drop rbx support for right now unless someone pipes up?

hundredwatt commented 9 years ago

Agreed, if someone pipes up, then we can revisit

hundredwatt commented 9 years ago

@hexgnu Dropped rbx, good to merge?

hundredwatt commented 9 years ago

This will close #208

solher commented 9 years ago

The thread safe fix with Faraday works perfectly ! No more segmentation fault. Thx a lot !

hundredwatt commented 9 years ago

@Solher Good to hear!