search

hexiro / spotify-to-musi

Transfer your Spotify playlists to Musi.
8 stars 1 forks source link

ValueError (too many values to unpack) #3

Closed Rasinzz closed 2 years ago

Rasinzz commented 2 years ago

Screenshot of error: image

hexiro commented 2 years ago

preciate it. could be that the video is less than a minute long or over an hour to where that code doesn't work. Regardless, I'll fix this next time I work on this (probably over the weekend)

Rasinzz commented 2 years ago

preciate it. could be that the video is less than a minute long or over an hour to where that code doesn't work. Regardless, I'll fix this next time I work on this (probably over the weekend)

Alright

hexiro commented 2 years ago

preciate it. could be that the video is less than a minute long or over an hour to where that code doesn't work. Regardless, I'll fix this next time I work on this (probably over the weekend)

Alright @Rasinzz I cleaned some stuff up a little bit. Give it a shot and let me know how it goes! If you have any more issues feel free to comment them here or to open a new issue.

Rasinzz commented 2 years ago

preciate it. could be that the video is less than a minute long or over an hour to where that code doesn't work. Regardless, I'll fix this next time I work on this (probably over the weekend)

Alright @Rasinzz I cleaned some stuff up a little bit. Give it a shot and let me know how it goes! If you have any more issues feel free to comment them here or to open a new issue.

Ok, sounds good. I'm currently in the middle of something. Once I get a change I'll try it out and let you know how it goes!

hexiro commented 2 years ago

No worries. Thank you for using my project!

Rasinzz commented 2 years ago

Ok, so I ran it and it was working flawlessly until I ran into an error towards the end. It was around 96% complete when I last looked at it, so I'm not sure if it finished and then gave me the error, or if it give me the error right before it was complete.

FYI: It did not print the Musi restore code.

lTXjIly .

hexiro commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Rasinzz commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Hey, I use the 'Local Files' setting to listen to some songs that are not on Spotify. For the local files option, it requires you to have the audio file on your local machine, so I assume the error is getting caused from a song from my local files (the file is probably poorly named or something. I'm going to make a new Spotify account and use the tool on a playlist that I know will 100% work and I'll get back to you.

hexiro commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Hey, I use the 'Local Files' setting to listen to some songs that are not on Spotify. For the local files option, it requires you to have the audio file on your local machine, so I assume the error is getting caused from a song from my local files (the file is probably poorly named or something. I'm going to make a new Spotify account and use the tool on a playlist that I know will 100% work and I'll get back to you.

oooh yikes I've never messed around with that. Does that work cross devices? If so then Spotify has to be storing some kind of data on their servers, but I've always assumed that was 100% local and couldn't be fetched by the API.

Rasinzz commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Hey, I use the 'Local Files' setting to listen to some songs that are not on Spotify. For the local files option, it requires you to have the audio file on your local machine, so I assume the error is getting caused from a song from my local files (the file is probably poorly named or something. I'm going to make a new Spotify account and use the tool on a playlist that I know will 100% work and I'll get back to you.

oooh yikes I've never messed around with that. Does that work cross devices? If so then Spotify has to be storing some kind of data on their servers, but I've always assumed that was 100% local and couldn't be fetched by the API.

No, it does not sync cross-devices. I just ran the tool on this playlist and it worked perfectly!

Rasinzz commented 2 years ago

Since I have local files in certain playlists, I would recommend adding an option that allows someone to link a playlist and just convert that playlist, as a way to combat this.

hexiro commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Hey, I use the 'Local Files' setting to listen to some songs that are not on Spotify. For the local files option, it requires you to have the audio file on your local machine, so I assume the error is getting caused from a song from my local files (the file is probably poorly named or something. I'm going to make a new Spotify account and use the tool on a playlist that I know will 100% work and I'll get back to you.

oooh yikes I've never messed around with that. Does that work cross devices? If so then Spotify has to be storing some kind of data on their servers, but I've always assumed that was 100% local and couldn't be fetched by the API.

No, it does not sync cross-devices. I just ran the tool on this playlist and it worked perfectly!

Nice! If you find a playlist it breaks on please let me know.

Rasinzz commented 2 years ago

damn. I'm not sure exactly why the name of the artist doesn't work for whatever song that is, if you wouldn't mind sending me your playlists I could maybe take a look and see if I can find it. Regardless, I'll push a fix that just skips the song if the artist name can't be found.

Hey, I use the 'Local Files' setting to listen to some songs that are not on Spotify. For the local files option, it requires you to have the audio file on your local machine, so I assume the error is getting caused from a song from my local files (the file is probably poorly named or something. I'm going to make a new Spotify account and use the tool on a playlist that I know will 100% work and I'll get back to you.

oooh yikes I've never messed around with that. Does that work cross devices? If so then Spotify has to be storing some kind of data on their servers, but I've always assumed that was 100% local and couldn't be fetched by the API.

No, it does not sync cross-devices. I just ran the tool on this playlist and it worked perfectly!

Nice! If you find a playlist it breaks on please let me know.

I'll put together a playlist with a local file in it so it breaks, real quick. I'll link it when I'm done.

hexiro commented 2 years ago

Since I have local files in certain playlists, I would recommend adding an option that allows someone to link a playlist and just convert that playlist, as a way to combat this.

This is a great idea. I'll turn it into a CLI where you can pass a playlist and if you don't it just does the playlists / liked songs. Not sure how long this will take but I'll either start it later today or tomorrow probably

Rasinzz commented 2 years ago

I'll put together a playlist with a local file in it so it breaks, real quick. I'll link it when I'm done.

Hey sorry for the wait, was out-n-about. Here's the link to the playlist: playlist

hexiro commented 2 years ago

ty

Rasinzz commented 2 years ago

ty

No problem. By the way, the songs that are greyed out are the ones that are local files.

Rasinzz commented 2 years ago

Ok, so it's able to find the local file songs, if they are named correctly. I guess the reason why I got the error is because some of songs were named poorly (for example, some were just named something random without any relation to the song itself... no artist name or song name)

hexiro commented 2 years ago

Do you think I should just skip local files, or should I search YouTube with the name of the local file? It's more likely to raise a false positive, but it's probably more convenient.

hexiro commented 2 years ago

For now i'm just going to skip local files because it's easier, but i'll rethink this in the future

Rasinzz commented 2 years ago

Do you think I should just skip local files, or should I search YouTube with the name of the local file? It's more likely to raise a false positive, but it's probably more convenient.

I would say allow users the option to choose if it does or does not search local files, but have it search local files by default.

hexiro commented 2 years ago

hopefully most common issues should be fixed for now. I'll revisit this tomorrow and see how I can transform it to a CLI :)

Rasinzz commented 2 years ago

hopefully most common issues should be fixed for now. I'll revisit this tomorrow and see how I can transform it to a CLI :)

Ok, great! I'll look into it also

hexiro commented 2 years ago

hopefully most common issues should be fixed for now. I'll revisit this tomorrow and see how I can transform it to a CLI :)

Ok, great! I'll look into it also

cli is in a good spot rn. don't think you can install it yet because I didn't finish the install script but you could run it locally with python -m spotify_to_musi inside the spotify-to-musi (note: dashes) directory if you'd like to try it out.

https://github.com/Hexiro/spotify-to-musi/tree/cli

hexiro commented 2 years ago

i also still need to include the functionality that makes it so you can select a playlist

Rasinzz commented 2 years ago

cli is in a good spot rn. don't think you can install it yet because I didn't finish the install script but you could run it locally with python -m spotify_to_musi inside the spotify-to-musi (note: dashes) directory if you'd like to try it out.

https://github.com/Hexiro/spotify-to-musi/tree/cli

Looking good

hexiro commented 2 years ago

closing as i believe this was resolved