search

hexojs / hexo-asset-pipeline

A hexo plugin to minify/optimize HTML, CSS, JS and images. Supports revisioning of assets.
30 stars 16 forks source link

Adding automated tests #20

Open ertrzyiks opened 6 years ago

ertrzyiks commented 6 years ago

Hey @bhaskarmelkani

I'm using this plugin on my both blog instances and also I'm developing test utils for hexo here: https://github.com/ertrzyiks/hexo-test-utils

So I thought, I could help you cover this plugin with automated tests to prove utils in battle and add all missing functionality to those utils if we notice any. I can do actual coding part, but before I start I would like to get your consent. If you like the idea, we can discuss what testing framework to use etc.

Cheers, Mateusz

TODO list

bhaskarmelkani commented 6 years ago

Hey @ertrzyiks,

Nice idea I am totally in for supporting you with it.

I personally like Jest. But if you prefer something else please feel free to suggest :)

ertrzyiks commented 6 years ago

Let it be Jest. I used it with ava for all my plugins, so having experience with other test runner is even better.

I will start by covering the case from #16 , so even if you fix it before me we will have a regression spec anyways :)

ertrzyiks commented 6 years ago

@bhaskarmelkani What do you think about enabling some CI like Travis?