search

hexojs / hexo-asset-pipeline

A hexo plugin to minify/optimize HTML, CSS, JS and images. Supports revisioning of assets.
29 stars 16 forks source link

Fix link to imagemin #31

Closed yoshinorin closed 5 years ago

tomap commented 6 years ago

why not https://github.com/imagemin/imagemin#plugins ?

yoshinorin commented 6 years ago

@tomap

Thanks. I worried which to use whether 'option' or 'plugin'. Finally I decide to use 'option'. But, I can't remember clearly reason. So, not important reason. So sorry...

By the way, Imagemin depends on some plugins. At first I tried to list up them and write to README. But, I didn't write them, because explanation become redundant.

Should I list up and write them? How do you think?

tomap commented 6 years ago

Nope, a link is enough. If someone struggle with this and posts an issue, we'll improve

bhaskarmelkani commented 6 years ago

Can you fix the build ?

tomap commented 6 years ago

Issue seems to be widespread and fix will come either with a dependency update or configuration change https://github.com/facebook/jest/issues/6766

tomap commented 6 years ago

PR #33 fixes it

yoshinorin commented 6 years ago

@tomap Thanks.

@bhaskarmelkani Would you tell me advice? Should I rebase my fix on to latest master & re-pull request ? I’m afraid that I don't familiar with GitHub develop style.

bhaskarmelkani commented 6 years ago

Hey,

You should rebase with the latest master and the push the branch.

tomap commented 6 years ago

Or someone should retrigger the build:)