search

hexojs / hexo-deployer-ftpsync

FTP deployer for Hexo
MIT License
23 stars 16 forks source link

Update the README.md #151

Closed pbw-Kevin closed 3 months ago

pbw-Kevin commented 3 months ago

While the new version of this plugin based on a new library,the application will not delete files and directories any more.

pbw-Kevin commented 3 months ago

And the parameters clear and verbose in official docs become invalid. Should those be updated?

stevenjoezhang commented 3 months ago

clear and verbose are still used: https://github.com/hexojs/hexo-deployer-ftpsync/blob/3ef51bedf2e54c82782de2544bc0aeb05e0cdc57/lib/deployer.js#L42 https://github.com/hexojs/hexo-deployer-ftpsync/blob/3ef51bedf2e54c82782de2544bc0aeb05e0cdc57/lib/deployer.js#L30

If these options are not working as expected, it could mean there is a bug.

stevenjoezhang commented 3 months ago

You can modify the documentation to say: 

If `clear` is set to true, this plugin will delete files and directories on the remote server to match the local machine. Use this plugin in production at your own risk.
pbw-Kevin commented 3 months ago

Well, it seems that it's my fault. After reinstall all the dependencies, every thing works well. README.md has changed. Sorry for my rudeness.

stevenjoezhang commented 3 months ago

Thank you, I'm glad to hear that the plugin is working well. If you encounter any issues, please feel free to report back!